Repository navigation
fix: respect Windows key casing when preserving existing env values - #278
Merged
gaborbernat merged 2 commits intoOct 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #277.
env_files_skip_if_set = truecan overwrite an existing variable on Windows when the dotenv key uses different casing. Windows'os.environnormalizes keys to uppercase, but thedict(os.environ)snapshot is queried using the unnormalized file spelling. The verbose report consequently saysSETrather thanSKIP.Normalize the snapshot lookup key on Windows, preserving the original key for assignment and reporting. Unix lookup remains case-sensitive. Four regression cases cover both platform rules and identical/different key spellings, including the reported action and preserved value.
Validation:
from_fileinstead offrom_environment.git diff --check.AI assistance: OpenAI Codex assisted with investigation, implementation, tests and this description. The Windows reproduction and hosted workflow were actually executed; no external model service or credentials were needed.