Allow ModbusBaseServer do directly accept a SimCore instance as context#2967
Open
km-64 wants to merge 2 commits into
Open
Allow ModbusBaseServer do directly accept a SimCore instance as context#2967km-64 wants to merge 2 commits into
km-64 wants to merge 2 commits into
Conversation
km-64
marked this pull request as ready for review
July 16, 2026 16:35
Collaborator
|
Please SimCore is an internal class, that we do not want as part of the API ! The reason being, when it is internal we can change it as needed without breaking the API. |
janiversen
requested changes
Jul 16, 2026
janiversen
left a comment
janiversen
left a comment
Collaborator
There was a problem hiding this comment.
This is a change that we do not want.
SimCore is internal and not part of the API. Please use the action function in SimDevice if you want to the content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to discussion #2966