Fix unit_diagonal and non-contiguous reads in MLX linalg - #2403
Open
jessegrabowski wants to merge 2 commits into
Open
Fix unit_diagonal and non-contiguous reads in MLX linalg#2403jessegrabowski wants to merge 2 commits into
jessegrabowski wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MLX's
solve_triangularhas nounit_diagonal, and the dispatch dropped the flag rather than emulating it, so it solved against A's real diagonal.lu_solvehit this too, since it hands the packed LU factor straight in and relies on the flag to ignore U's diagonal.Second, unrelated:
mx.arraykeeps a non-C-contiguous numpy layout and MLX's elementwise kernels misread the buffer, somlx_typifynormalizes to C order. That madelu_solve's gradient wrong, and reverting it segfaults rather than failing on the numbers, so the read is going out of bounds.Closes #2384