Update from task 2064bbbd-4fcf-4e5c-98d7-278b9d52f56f - #8
Open
pydevcasts wants to merge 5 commits into
Open
Conversation
-Key features implemented: -Updated default model names in compare_models_nested_cv from "RandomForest" and "LogisticRegression" to "Random Forest" and "Logistic Regression" for consistent naming convention -Modified core/src/pipeline.py to ensure proper string matching with build_model function requirements -Fixed potential model building failures due to inconsistent naming between comparison function and model factory The changes ensure proper model instantiation across the pipeline by maintaining consistent naming conventions between the comparison utility and the underlying model building system.
…workflow Key features implemented: - Added comprehensive .gitignore files for core project and root directory to exclude data files, models, cache, and IDE artifacts - Refactored feature selection from complex 3-layer pipeline to simpler MI-based approach with variance threshold and 7 engineered features - Updated feature selection notebook (04) to use simplified pipeline and properly handle clinical/engineered feature separation - Modified model training notebook (05) to load fitted selector artifacts and apply consistent feature transformation to test data - Implemented proper data transformation workflow including imputation, variance filtering, and MI selection for test/external datasets - Added engineered feature creation logic with Gleason scores, pathway analysis, and clinical interactions The changes streamline the feature selection process while maintaining domain-specific engineering, improve test data handling consistency, and resolve previous pipeline errors related to feature name mismatches between training and test sets.
Key features implemented: - Refactored feature_selection.py to use simple MI-based pipeline instead of 3-layer approach - Updated notebooks 04 and 05 to align with simplified feature selection workflow - Fixed ValueError in transform_selected by ensuring feature alignment between fit and transform - Added core/.gitignore file to exclude data files and outputs from version control - Modified .gitignore to properly track source files while ignoring compiled outputs The changes resolve the feature name mismatch error during transformation by implementing consistent feature alignment and simplifying the overall feature selection architecture.
…investigation-of-suspicious-codes-2f56f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by qwen-chat coder for task 2064bbbd-4fcf-4e5c-98d7-278b9d52f56f.