Skip to content

Update grouped models - #974

Open
NicolaCourtier wants to merge 41 commits into
developfrom
grouped-voltage-components
Open

Update grouped models#974
NicolaCourtier wants to merge 41 commits into
developfrom
grouped-voltage-components

Conversation

@NicolaCourtier

Copy link
Copy Markdown
Member

Description

The main additions are:

  • voltage components for each grouped model to enable PyBaMM's plot_voltage_components
  • asymmetric and multiphase Butler-Volmer kinetics

Smaller changes:

  • use "positive" domain naming for the SPDiffusion and WeppnerHuggins models
  • remove the adjustment of the OCV that forces it to blow up at the stoichiometry limits
  • use the "U__c_s" tolerance for the stoichiometric event tolerance instead
  • get the reaction rate parameter values from PyBaMM exchange current densities
  • use relative transport efficiencies instead of electrolyte diffusion times for each layer
  • update the SPDiffusion model to use SOC instead of stoichiometry

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #).

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: $ pre-commit run or $ nox -s pre-commit (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctest
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.18182% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.91%. Comparing base (3171a07) to head (eef65c0).
⚠️ Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
pybop/models/lithium_ion/alternative_functions.py 80.00% 5 Missing ⚠️
pybop/models/lithium_ion/grouped_spm.py 90.47% 4 Missing ⚠️
pybop/models/lithium_ion/grouped_spme.py 92.15% 4 Missing ⚠️
pybop/applications/gitt_methods.py 0.00% 1 Missing ⚠️
pybop/models/lithium_ion/sp_diffusion.py 98.59% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #974      +/-   ##
===========================================
+ Coverage    92.13%   92.91%   +0.77%     
===========================================
  Files           74       82       +8     
  Lines         5799     6786     +987     
===========================================
+ Hits          5343     6305     +962     
- Misses         456      481      +25     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants