Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging continuous verification summaries currently changes the first input: the shallow dictionary copy still shares its NumPy arrays. Reusing those summaries for another aggregate then counts data twice. For example, merging two three-sample summaries changes the first summary's count to six; repeating the merge returns nine samples instead of six.
This deep-copies the first summary before updating its moments and counts. The second input remains read-only. Tests cover scalar, axis-wise and per-pixel summaries, repeated merges, reversed inputs and later accumulation into the merged result.
I also checked repeated aggregation of actual Finnish and Swiss radar forecast errors against direct NumPy population moments. All 144 checks that failed because of input mutation now pass, and the previously working controls are unchanged.
Validation: 804 tests pass in the full suite; both plugin tests pass when rerun after installing the missing
pipdependency. One optional GDAL module is skipped. The focused tests and radar checks also pass on Python 3.11 / NumPy 1.26, and Black passes.