Skip to content

Parameterize temperature conversion tests in both package examples - #844

Open
qorud02 wants to merge 2 commits into
pyOpenSci:mainfrom
qorud02:codex/parametrize-temperature-examples
Open

qorud02 wants to merge 2 commits into
pyOpenSci:mainfrom
qorud02:codex/parametrize-temperature-examples

Conversation

@qorud02

@qorud02 qorud02 commented Nov 12, 2026

Copy link
Copy Markdown

Addresses #802.

Replace the six repeated positive/negative/zero temperature-conversion tests in each example with two parametrized tests, following the discussion in #659. Keep named cases and the negative Celsius result for 0°F; use pytest.approx with the existing absolute tolerance.

The Hatch-only averaging/workflow examples and the fixture-based annual-mean tests stay in place. The two excerpts included by tests/test-types.md are byte-identical to the originals.

Validation:

  • Each package runs in a separate Python process: Hatch 11 tests and setuptools 8 tests pass.
  • Ruff checks pass using the example-specific configuration.
  • nox -e docs-test passes, including the strict English build and the notified release-language builds.
  • Verification run. Both changed files match the tested blobs; verification workflow changes stay on a separate fork branch.

@netlify

netlify Bot commented Nov 12, 2026

Copy link
Copy Markdown

👷 Deploy request for python-package-guide pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8bf541d

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant