Raise ParseError, not StopIteration, from readOne on an empty stream - #145
Merged
Merged
Conversation
readOne returns next(readComponents(...)). An empty or whitespace-only stream produces no components, so next() raised a bare StopIteration out of readOne. Catch it and raise ParseError instead.
da4089
self-requested a review
August 16, 2026 00:39
|
Looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vobject.readOne('')(or any whitespace-only input) raises a bareStopIterationinstead of aParseError:readOnereturnsnext(readComponents(...)), and an empty or whitespace-only stream yields no components, sonext()raisesStopIterationstraight out ofreadOne. I catch it and raiseParseErrorinstead, consistent with how the other malformed-input cases are reported.Added a
test_empty_streamnext totest_bad_stream; it raises StopIteration onmasterand passes with the change, and the parsing suite still passes. Found it by fuzzingreadOne.