Repository navigation
Fix analytical solar azimuth at northward solar noon - #2907
Open
vera-rubin wants to merge 1 commit into
Open
vera-rubin wants to merge 1 commit into
vera-rubin wants to merge 1 commit into
Conversation
Use the morning branch for zero hour angle so northward noon returns zero radians. Add regression coverage for signed zero, scalar and array inputs, pandas Series, and a southward-noon control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solar_azimuth_analyticalin pvlib 0.16.2.dev10+g49530b4dc returns 180° for latitude -35°, hour angle 0°, declination 0°, and zenith 35°; spherical geometry gives 0° (due north).We use the morning branch at zero hour angle to preserve the northward direction. We verified the regression fails before the fix and passes afterward, ran the solar-position test module, and checked independent spherical projections.
— ChipLab