Modernize: skillcheck lint, PR/issue templates, CI dedup, setup-vp pin - #71
Merged
Conversation
Exact-pin @uinaf/skillcheck 0.4.0, add a skills:lint script, and chain it into the verify gate so CI's Verify CLI job covers skill lint. Transitive build scripts stay disabled; the lint needs none of them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…scription Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The verify script already runs smoke:pack; the standalone CI step ran it a second time. The setup-vp composite action now uses the same v1.15.0 SHA as backfill-release-assets.yml. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR modernizes the repo’s maintenance and verification workflow by adding skill linting to the existing verify pipeline, deduplicating CI steps, and improving contributor ergonomics via templates and agent guidance.
Changes:
- Add
@uinaf/skillcheck(exact-pinned) and askills:lintscript, chaining it intoverify. - Deduplicate CI by removing the standalone
smoke:packstep now thatverifyruns it. - Add PR template + YAML issue forms (and disable blank issues), plus refresh agent docs and pin
setup-vpto the intended SHA.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
skills/putio-cli/SKILL.md |
Moves the “consumer-only” boundary into frontmatter so skill metadata carries the constraint. |
pnpm-workspace.yaml |
Denies build scripts for select transitive deps and excludes the newly pinned skillcheck from minimum-release-age gating. |
package.json |
Adds skills:lint and wires it into verify; introduces exact-pinned @uinaf/skillcheck. |
AGENTS.md |
Surfaces focused commands (dead-code, skills lint, smoke pack, SEA flows) and the smoke report path. |
.github/workflows/ci.yml |
Removes redundant CI step now covered by vp run verify. |
.github/pull_request_template.md |
Adds a lightweight PR template scaffold (Summary/Verification/Notes). |
.github/ISSUE_TEMPLATE/feature_request.yml |
Adds a feature request issue form. |
.github/ISSUE_TEMPLATE/bug_report.yml |
Adds a bug report issue form with structured prompts. |
.github/ISSUE_TEMPLATE/config.yml |
Disables blank issues to route reporters through issue forms. |
.github/actions/setup-vp/action.yml |
Pins voidzero-dev/setup-vp to the desired v1.15.0 SHA for consistency. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
🎉 This PR is included in version 1.6.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #70
@uinaf/skillcheck0.4.0, addskills:lint, chain it intoverify; the CIVerify CLIjob now covers skill lint with no extra step, no secrets.description("Do not use when developing this repository itself.")..github/pull_request_template.md(Summary/Verification/Notes) and YAML issue forms withblank_issues_enabled: false.setup-vp/action.ymlto the v1.15.0 SHA already used inbackfill-release-assets.yml.smoke:packCI step;verifyalready runs it.check:dead-code,skills:lint,smoke:pack,build:sea/verify:sea, and the.artifacts/smoke-packed-install.jsonreport path, routing detail to CONTRIBUTING.md.Verification
pnpm exec vp run verifyexit 0; chain includesskill lint: 1 package(s) clean(exactly 1 skill found atskills/putio-cli/).actionlintclean; all 6 touched/added YAML files parse.Notes
@playwright/browser-chromium,@swc/core,onnxruntime-node,protobufjs,sharp); they are denied inallowBuildssince the lint needs no build scripts — same approach as putdotio/putio-frontend#26.esbuildstaystrue: pre-existing, direct devDependency forbuild:sea.@uinaf/skillcheck@0.4.0added tominimumReleaseAgeExclude(pnpm loose mode; release younger than the configured floor).