test: replace maintainer identity in fixtures with synthetic values - #68
Closed
altaywtf wants to merge 1 commit into
Closed
test: replace maintainer identity in fixtures with synthetic values#68altaywtf wants to merge 1 commit into
altaywtf wants to merge 1 commit into
Conversation
Public repo shipped altay@put.io and username "altay" in test fixtures. Replace with user@example.com / example-user; assertions unchanged in shape. Fixes #65 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR removes a real maintainer identity from test fixtures by replacing altay@put.io / altay with clearly synthetic values (user@example.com / example-user) across the CLI’s test suite and test-support mocks, keeping assertion shapes unchanged.
Changes:
- Updated whoami/account fixture data in test mocks and command-path tests to use synthetic email/username values.
- Updated internal command tests to assert the new synthetic username values.
- Updated terminal formatting tests to use synthetic string input instead of a real username.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/test-support/command-path-mocks.ts | Replaces account fixture mail and username with synthetic values used by command-path tests. |
| src/internal/terminal/format.test.ts | Updates formatNullable test input/output assertions to avoid real identity strings. |
| src/internal/command.test.ts | Updates selectTopLevelFields fixture/assertions to use the synthetic username. |
| src/command-paths.test.ts | Updates whoami command-path fixtures and JSON output assertions to use synthetic mail/username values. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
Auto-closed by GitHub when the base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: the public repo shipped
altay@put.ioandusername: "altay"in test fixtures:src/command-paths.test.ts,src/internal/command.test.ts, plus two occurrences beyond the issue list insrc/test-support/command-path-mocks.tsandsrc/internal/terminal/format.test.ts(all fixtures).Solution: replace with
user@example.com/example-useracross all 4 files (11 lines); assertions keep the same shapes.git grep -i altayis empty in tracked files.Based on
fix/effect-rc-driftbecause full verify (the pre-push gate) needs #67's Effect pin; re-target tomainonce #67 merges.vp run verifygreen on the rebased branch.Fixes #65
🤖 Generated with Claude Code