Skip to content

fix: honor the transfers watch deadline, keep rate-limit and --json error detail - #179

Merged
altaywtf merged 3 commits into
mainfrom
fix/audit-followups
Nov 12, 2026
Merged

altaywtf merged 3 commits into
mainfrom
fix/audit-followups

Conversation

@altaywtf

@altaywtf altaywtf commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Summary

Three error-path fixes from the Effect audit.

Case Before Now
transfers watch --timeout-seconds 3 --interval-seconds 60 returns after 60 s returns after 3 s
429 during auth login (device poll or token check) Device login failed or a connection hint Rate limited, with retry and captcha hints
--json payload fails its schema Expected --json to match the command input schema. same, plus the issue and its path, such as ["parent_id"]

Verification

  • pnpm exec vp run verify
  • The deadline and rate-limit tests fail with each fix reverted.
  • Built binary driven through verify-putio-cli: the watch returned in 3.4 s with polls 3 s apart.

Notes

…rror detail

`transfers watch` slept the full interval before checking the deadline, so
`--timeout-seconds 3 --interval-seconds 60` returned after a minute. The
loop now sleeps no longer than the time left.

Device login polling and token validation replaced every SDK error with a
generic message. A rate limit now reaches its localizer, with the retry
and captcha hints.

A `--json` payload that fails its schema names the failing path.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T18:11:41.359831Z a060f51 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cfba15c5b7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/commands/transfers.ts Resolved
The fixture API serves one transfer that never finishes and one that has,
and the feature map gains the watch recipe.
@altaywtf
altaywtf merged commit bb8539a into main Nov 12, 2026
6 checks passed
@altaywtf
altaywtf deleted the fix/audit-followups branch November 12, 2026 18:18
putio-ci Bot added a commit that referenced this pull request Nov 12, 2026
## [1.10.6](v1.10.5...v1.10.6) (2026-11-12)

### Bug Fixes

* honor the transfers watch deadline, keep rate-limit and --json error detail ([#179](#179)) ([bb8539a](bb8539a))
@putio-ci

putio-ci Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.10.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@putio-ci putio-ci Bot added the released label Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant