Skip to content

fix: stop reporting invalid input as a crash, gate on Effect diagnostics - #178

Merged
altaywtf merged 2 commits into
mainfrom
chore/effect-diagnostics
Nov 12, 2026
Merged

altaywtf merged 2 commits into
mainfrom
chore/effect-diagnostics

Conversation

@altaywtf

Copy link
Copy Markdown
Member

Summary

Invalid input no longer raises a crash report, and Effect diagnostics now run in the gate.

$ putio files hls-manifest 0        # before: error printed, crash report sent
$ putio files hls-manifest 0        # now: same error, no report

$ pnpm exec vp run check            # with a stray Effect.log("floating")
x effecttsgo(floating-effect): This Effect value is neither yielded nor used in an assignment.
  • download-links create without a selection prints its own message again.
  • @effect/tsgo 0.68.1 is under a day old, so it has a minimumReleaseAgeExclude entry.
  • Bare vp check fails; use vp run check.

Verification

  • pnpm exec vp run verify
  • Six command-path tests fail on main once the harness records crash reports.
  • Built binary driven through verify-putio-cli.

Notes

No real crash endpoint used.

Validators that throw ran outside Effect.try in several command handlers,
so a typo such as `putio files hls-manifest 0` became a defect and raised
a crash report. They now fail as CliCommandInputError. The command-path
harness records crash reports and expects none on an expected failure.
`download-links create` without a selection prints its own message again.

@effect/tsgo adds the Effect correctness and strict diagnostics to
`vp run check`, the verify gate and the staged hook. The fixes they asked
for are equivalent forms. Rules that would change exported shapes or that
the dynamic SDK call cannot satisfy are off by file in vite.config.ts.
tsconfig lists the unstable Effect modules the CLI accepts and no longer
asks for declaration output nothing consumes.

@effect/tsgo and its platform packages are exempt from the pnpm release
age: 0.68.1 is under a day old.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T17:00:59.786069Z 07e1062 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 07e10627c8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/cli.ts Resolved
The correctness preset only warns, and warnings do not fail the check.
AGENTS.md links unshipped files by URL.
@altaywtf
altaywtf merged commit 9f488f3 into main Nov 12, 2026
6 checks passed
@altaywtf
altaywtf deleted the chore/effect-diagnostics branch November 12, 2026 17:14
putio-ci Bot added a commit that referenced this pull request Nov 12, 2026
## [1.10.5](v1.10.4...v1.10.5) (2026-11-12)

### Bug Fixes

* stop reporting invalid input as a crash, gate on Effect diagnostics ([#178](#178)) ([9f488f3](9f488f3))
@putio-ci

putio-ci Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.10.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@putio-ci putio-ci Bot added the released label Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant