Repository navigation
fix: stop reporting invalid input as a crash, gate on Effect diagnostics - #178
Conversation
Validators that throw ran outside Effect.try in several command handlers, so a typo such as `putio files hls-manifest 0` became a defect and raised a crash report. They now fail as CliCommandInputError. The command-path harness records crash reports and expects none on an expected failure. `download-links create` without a selection prints its own message again. @effect/tsgo adds the Effect correctness and strict diagnostics to `vp run check`, the verify gate and the staged hook. The fixes they asked for are equivalent forms. Rules that would change exported shapes or that the dynamic SDK call cannot satisfy are off by file in vite.config.ts. tsconfig lists the unstable Effect modules the CLI accepts and no longer asks for declaration output nothing consumes. @effect/tsgo and its platform packages are exempt from the pnpm release age: 0.68.1 is under a day old.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07e10627c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The correctness preset only warns, and warnings do not fail the check. AGENTS.md links unshipped files by URL.
## [1.10.5](v1.10.4...v1.10.5) (2026-11-12) ### Bug Fixes * stop reporting invalid input as a crash, gate on Effect diagnostics ([#178](#178)) ([9f488f3](9f488f3))
|
🎉 This PR is included in version 1.10.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Invalid input no longer raises a crash report, and Effect diagnostics now run in the gate.
download-links createwithout a selection prints its own message again.@effect/tsgo0.68.1 is under a day old, so it has aminimumReleaseAgeExcludeentry.vp checkfails; usevp run check.Verification
pnpm exec vp run verifymainonce the harness records crash reports.verify-putio-cli.Notes
No real crash endpoint used.