Skip to content

feat(mobile): phone and tablet show the player notices iOS shows - #843

Open
altaywtf wants to merge 3 commits into
mainfrom
fix/835-player-strings
Open

altaywtf wants to merge 3 commits into
mainfrom
fix/835-player-strings

Conversation

@altaywtf

Copy link
Copy Markdown
Member

Change

Phone and tablet show the six player strings iOS shows, each on its real trigger.

Copy Trigger
Couldn’t load subtitles Subtitle list or chosen subtitle fails; playback continues without it
Couldn’t switch audio track Decoder fails right after an audio pick; previous track returns
Loading on Cast receiver hasn't played the file yet
Could not convert video put.io refuses the conversion start
The video could not be played. Try again. Player fault with no put.io cause
Get VLC Action on the Files "Install VLC" notice
  • Track recovery moves from tv to domain/playback; TV keys and behaviour stay.

Closes #835

Validation

  • verifyMobile, verifyTv, verifyLibraries
  • Domain and mobile unit tests pin each trigger

Unverified: device QA, done in a separate pass.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T17:35:05.025092Z 54fcc67 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@altaywtf
altaywtf force-pushed the fix/835-player-strings branch from 6618c64 to f3787a2 Compare November 15, 2026 14:41
@altaywtf

Copy link
Copy Markdown
Member Author

Device QA blocked; not merged.

Check Result
Codex audit 2 findings, both fixed in f3787a2: notices hidden in picture-in-picture; a Cast reconnect keeps the played label
verifyMobile + player and Cast label tests (devbox, f3787a2) pass
:mobile:assembleProductionDebug + install on Pixel pass
Pixel QA (Get VLC, conversion refusal, player fault, track failures) not run: the Pixel sits at a secure lock screen, and adb can't unlock it
Crash buffer empty

Next: unlock the Pixel, then rerun the device pass.

@altaywtf
altaywtf force-pushed the fix/835-player-strings branch from 2338dfc to 54fcc67 Compare November 15, 2026 17:33

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Player: add the Playback strings iOS shows and Android lacks

1 participant