Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91b95f6812
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Not merged yet: device QA is blocked.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c6ec31c8f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (event is FilesBrowserEvent.TrashUndone) pinnedFiles?.trashUndone(event.outcome) | ||
| browser.dispatch(event) |
There was a problem hiding this comment.
Restore hidden pins when items are restored from Trash
If a user trashes a pinned item in a nested folder, navigates out of that folder, and later restores the item from the Trash screen rather than using Undo, its pin remains hidden. MobileShell.TrashRestoreEffects emits InvalidateRestoredItem (or InvalidateAllFolders for bulk restores), but this callback only informs pinned files about TrashUndone. The browser invalidation only marks folders stale, and once the original folder has left the stack there is no delete outcome for follow() to reconcile, so PinnedItems.removed continues suppressing the restored item until a manual root refresh or session restart. Forward confirmed Trash-screen restores to the pinned resolver as well.
Useful? React with 👍 / 👎.
Mobile Files and TV Home now share PinnedItems in domain/files. Mobile Pinned follows rename, move and confirmed trash outcomes and Undo, shows a refused pin over the viewer and the player, and sends a revoked session from the pin reads to sign-out. Refs #742
itemEdited re-read every pin through retry(), which cleared the removed set, so a pin in Trash read as gone and lost its saved pin before Undo. It now refreshes without clearing removed or gone. The card builders move to file level so PinnedItems passes detekt TooManyFunctions. Regenerates the TV baseline profile after the pinned row moved to the shared resolver.
c6ec31c to
096b3a3
Compare
Change
Mobile Pinned now stays current like TV Home, because both apps use one resolver,
PinnedItemsindomain/files.TvHomePinsand its row and card types.Closes #742
Validation
verifyMobile,verifyTvand the module tests on the devbox; CI runs fullverifyUnverified: Pixel device QA, baseline profile regeneration.