Skip to content

fix(mobile,tv): Pinned keeps up with renames, moves and Trash on mobile - #842

Open
altaywtf wants to merge 5 commits into
mainfrom
fix/742-shared-pin-resolver
Open

altaywtf wants to merge 5 commits into
mainfrom
fix/742-shared-pin-resolver

Conversation

@altaywtf

Copy link
Copy Markdown
Member

Change

Mobile Pinned now stays current like TV Home, because both apps use one resolver, PinnedItems in domain/files.

Mobile case After
Rename or move a pinned item Pinned reads it again
Trash, then Undo Row hidden, then back; pin kept
Pin refused in the viewer or player Notice shows there
401 while pins load Signs out
  • TV only renames TvHomePins and its row and card types.
  • Risk: the TV baseline profile still lists the old class names.

Closes #742

Validation

  • Code changes: verifyMobile, verifyTv and the module tests on the devbox; CI runs full verify
  • Proof for each matching row of the AGENTS.md proof map

Unverified: Pixel device QA, baseline profile regeneration.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T17:35:50.936289Z 096b3a3 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 91b95f6812

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@altaywtf

Copy link
Copy Markdown
Member Author

Not merged yet: device QA is blocked.

Check Result
Codex audit 2 real findings, fixed in 49a62ed
Pinned, MobilePinnedFiles, list-detail and TV Home tests, verifyMobile, verifyTv (devbox) pass
Negative control: both new tests with the fix reverted fail, as expected
Pixel QA: rename, move, trash/restore, pin from viewer not run: the Pixel is locked with a PIN
TV QA deferred to the Mi Box pass
  • A trash that a folder reload contradicts (STILL_PRESENT) now shows the pin again.
  • Try again clears the list of gone ids, so a failed stale-pin unpin gets retried, as on main.
  • Still open: the TV baseline profile still lists TvHomePins. Regenerate it on an emulator.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c6ec31c8f4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +264 to +265
if (event is FilesBrowserEvent.TrashUndone) pinnedFiles?.trashUndone(event.outcome)
browser.dispatch(event)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore hidden pins when items are restored from Trash

If a user trashes a pinned item in a nested folder, navigates out of that folder, and later restores the item from the Trash screen rather than using Undo, its pin remains hidden. MobileShell.TrashRestoreEffects emits InvalidateRestoredItem (or InvalidateAllFolders for bulk restores), but this callback only informs pinned files about TrashUndone. The browser invalidation only marks folders stale, and once the original folder has left the stack there is no delete outcome for follow() to reconcile, so PinnedItems.removed continues suppressing the restored item until a manual root refresh or session restart. Forward confirmed Trash-screen restores to the pinned resolver as well.

Useful? React with 👍 / 👎.

Mobile Files and TV Home now share PinnedItems in domain/files. Mobile
Pinned follows rename, move and confirmed trash outcomes and Undo, shows
a refused pin over the viewer and the player, and sends a revoked
session from the pin reads to sign-out.

Refs #742
itemEdited re-read every pin through retry(), which cleared the removed
set, so a pin in Trash read as gone and lost its saved pin before Undo.
It now refreshes without clearing removed or gone. The card builders
move to file level so PinnedItems passes detekt TooManyFunctions.

Regenerates the TV baseline profile after the pinned row moved to the
shared resolver.
@altaywtf
altaywtf force-pushed the fix/742-shared-pin-resolver branch from c6ec31c to 096b3a3 Compare November 15, 2026 17:33

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Share the pin resolver between mobile Files and TV Home

1 participant