Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc3adc943e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Not merged. The service-only gap is still open, and device QA didn't run.
Next step: hold back the notification only while a controller owns the retry, or run the re-ask from the service. |
…put.io again A Direct play video whose lookup gets no answer, as when the device is offline, starts as the converted MP4. A file with no converted copy, such as an original MP4, then fails with 404 once the network returns and the row shows No longer available until Retry asks again. The row now remembers the lookup went unanswered. When that stand-in is refused before its first byte, the controller asks put.io again and starts the answer, with no failure notification. A second unanswered lookup leaves the row failed, so it never loops. Closes #763
…s refusal A notification Try again that gets no answer marks the already-refused row unanswered while it starts the stand-in itself. The controller re-asked on that write too, so two starts raced for the same download.
… a controller asks again DownloadsController lives in the Downloads view model, so a refusal reached by the download service alone (process death, scheduler, boot) had no owner to re-ask Direct play and the user heard nothing. The view model now holds a per-account redecider while its controller runs; without one the failure notification posts and the next controller re-asks on open.
1b82bbd to
3b3431d
Compare
Change
A Direct play download that waited offline now starts when the network returns, with no Retry.
Closes #763
Validation
./gradlew verifyMobile:mobile:testProductionDebugUnitTest --tests "io.putdotio.android.downloads.*"; the two newDownloadMethodsTestcases fail onmainUnverified: device QA on the Pixel.