Skip to content

fix(mobile,tv): turning off Trash says it empties Trash now - #840

Merged
altaywtf merged 1 commit into
mainfrom
fix/788-trash-off-copy
Nov 15, 2026
Merged

altaywtf merged 1 commit into
mainfrom
fix/788-trash-off-copy

Conversation

@altaywtf

Copy link
Copy Markdown
Member

Change

Turning off Trash now says it empties Trash right away, as the server does.

Copy
Before Deleted files will no longer be recoverable. Files already in trash stay for their 14 days.
After Turning off trash empties it now. Files you delete after that can’t be restored.
  • Same message on mobile Settings and TV Account; matches the web app.

Closes #788

Validation

  • Affected mobile and TV account tests

Unverified: verify runs in CI; no device check, since turning Trash off empties the shared account's Trash.

The server empties Trash when the setting goes off, as the web app's
confirmation already says. The old copy promised 14 more days.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T13:58:12.736319Z d3153bc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@altaywtf
altaywtf merged commit 16a8a19 into main Nov 15, 2026
5 checks passed
@altaywtf
altaywtf deleted the fix/788-trash-off-copy branch November 15, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Turn off Trash says trashed files stay 14 days, but Trash is emptied

1 participant