Skip to content

perf(tv): History hand-off never compares whole lists on the main thread - #837

Merged
altaywtf merged 1 commit into
mainfrom
perf/tv-history-handoff-keys
Nov 15, 2026
Merged

altaywtf merged 1 commit into
mainfrom
perf/tv-history-handoff-keys

Conversation

@altaywtf

Copy link
Copy Markdown
Member

The last-row hand-off in TV History keyed its effect on the whole entry list. Compose compares effect keys with equals, so each changed same-size refresh walked the list on the main thread. It now keys on the list size and last row key, the only parts the effect reads.

LaunchedEffect(handOff.pending.value, built, entries.size, entries.lastOrNull()?.key)

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T10:02:05.335856Z 9cc4d36 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@altaywtf
altaywtf merged commit 97148bb into main Nov 15, 2026
5 checks passed
@altaywtf
altaywtf deleted the perf/tv-history-handoff-keys branch November 15, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant