Repository navigation
fix: make the first Maven Central release LGPL-complete - #2
Merged
Merged
Conversation
Maven Central releases cannot be replaced, so every gap must close before the first tag. - Publish the pinned FFmpeg tree, JNI wrapper and build scripts as an ffmpeg-source artifact of the publication, so LGPL source sits next to the binary, signed with it. - verify now publishes to Maven Local and asserts the POM, sources and javadoc jars, AAR and ffmpeg-source; CI runs it with a release-shaped version and a throwaway signing key. - check-aar enforces the decoder set per ABI and fails on an empty or host-specific configure line. - A VERSION file makes av_version_info report the FFmpeg tag instead of this repository's git describe. It is removed from the staged tree after the FFmpeg build, because on a case-insensitive file system it shadows the C++ <version> header. - Negative controls run in verify and prove those checks fail. - Renovate skips the release age for submodules: git-refs has no timestamps, so updates stalled.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The wrapper failed twice on a 10 second read timeout with no retry, and a release tag run would hit the same failure.
FFmpeg n7.1.5 builds GPL-headed aarch64 ac3dsp files without a CONFIG_GPL gate, so a configure line that says LGPL still shipped GPL object code in the arm64 library. A staged patch drops those files from the build and keeps the ac3 and eac3 decoders on the C implementation. Staging also deletes every other GPL-headed file, and a new gate scans the objects compiled into each ABI. The AAR and NOTICE now carry FFmpeg's LICENSE.md and every compiled non-LGPL notice, the POM uses one combined license entry, and BUILD.txt gives the rebuild and relink commands.
The classifier returned lgpl for any header containing that word, so vf_owdenoise.c stayed in the source archive. The relink command in BUILD.txt also left a libc++_shared.so dependency the released library does not have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the known gaps before the first tag: Maven Central never replaces a version.
ac3dspNEON compiled inconfigureLicense lineLICENSE.mdand compiled non-LGPL noticesffmpeg-source.tar.xz: built tree, patch, relink commandsffmpeg-build.txtav_version_info()git describen7.1.5vsRELEASEac3dsp.candaarch64/Makefile; staging deletes every GPL-headed file.verifyasserts each Maven Local artifact; negative controls prove each check fails.+in the version, AC-3 playback on arm64.