Skip to content

fix: make the first Maven Central release LGPL-complete - #2

Merged
altaywtf merged 4 commits into
mainfrom
fix/first-release-readiness
Nov 8, 2026
Merged

altaywtf merged 4 commits into
mainfrom
fix/first-release-readiness

Conversation

@altaywtf

@altaywtf altaywtf commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

Closes the known gaps before the first tag: Maven Central never replaces a version.

Before Now
arm64 AC-3 GPL ac3dsp NEON compiled in Patched out, C only
GPL check configure License line Headers of objects compiled per ABI
Notices LGPL text LICENSE.md and compiled non-LGPL notices
LGPL source Gitlink Signed ffmpeg-source.tar.xz: built tree, patch, relink commands
POM Apache-2.0 One combined entry
ffmpeg-build.txt One ABI Each ABI
Decoders Unchecked Exact set
av_version_info() git describe n7.1.5 vs RELEASE
  • The patch and dated notices touch ac3dsp.c and aarch64/Makefile; staging deletes every GPL-headed file.
  • verify asserts each Maven Local artifact; negative controls prove each check fails.
  • BUILD.txt's commands relinked arm64-v8a from an unpacked archive.
  • Not exercised: Central's validation, + in the version, AC-3 playback on arm64.

Maven Central releases cannot be replaced, so every gap must close
before the first tag.

- Publish the pinned FFmpeg tree, JNI wrapper and build scripts as an
  ffmpeg-source artifact of the publication, so LGPL source sits next to
  the binary, signed with it.
- verify now publishes to Maven Local and asserts the POM, sources and
  javadoc jars, AAR and ffmpeg-source; CI runs it with a release-shaped
  version and a throwaway signing key.
- check-aar enforces the decoder set per ABI and fails on an empty or
  host-specific configure line.
- A VERSION file makes av_version_info report the FFmpeg tag instead of
  this repository's git describe. It is removed from the staged tree
  after the FFmpeg build, because on a case-insensitive file system it
  shadows the C++ <version> header.
- Negative controls run in verify and prove those checks fail.
- Renovate skips the release age for submodules: git-refs has no
  timestamps, so updates stalled.
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T13:10:26.756383Z 143fd61 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

The wrapper failed twice on a 10 second read timeout with no retry, and a release tag run would hit the same failure.
FFmpeg n7.1.5 builds GPL-headed aarch64 ac3dsp files without a CONFIG_GPL
gate, so a configure line that says LGPL still shipped GPL object code in
the arm64 library.

A staged patch drops those files from the build and keeps the ac3 and eac3
decoders on the C implementation. Staging also deletes every other
GPL-headed file, and a new gate scans the objects compiled into each ABI.
The AAR and NOTICE now carry FFmpeg's LICENSE.md and every compiled
non-LGPL notice, the POM uses one combined license entry, and BUILD.txt
gives the rebuild and relink commands.
The classifier returned lgpl for any header containing that word, so
vf_owdenoise.c stayed in the source archive. The relink command in BUILD.txt
also left a libc++_shared.so dependency the released library does not have.
@altaywtf
altaywtf merged commit 1d9e66a into main Nov 8, 2026
2 checks passed
@altaywtf
altaywtf deleted the fix/first-release-readiness branch November 8, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant