Skip to content

fix: sg leaking types #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kieronlanning merged 1 commit into from
Sep 24, 2026
Merged

fix: sg leaking types #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
<RoslynVersion>5.9.0</RoslynVersion>
<TUnitVersion>1.67.0</TUnitVersion>
<PurviewSGFVersion>1.0.0-prerelease.50</PurviewSGFVersion>
<PurviewSGFVersion>1.0.0-prerelease.51</PurviewSGFVersion>
<DotnetRuntimeVersion>10.0.12</DotnetRuntimeVersion>
<MSExtensionVersion>10.10.0</MSExtensionVersion>
<OpenTelemetryVersion>1.18.0</OpenTelemetryVersion>
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "purview-telemetry-sourcegenerator",
"version": "5.0.0-prerelease.15",
"version": "5.0.0-prerelease.16",
"description": "Generates [`ActivitySource`](https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.activitysource), [`ILogger`](https://learn.microsoft.com/en-us/dotnet/api/microsoft.extensions.logging.ilogger), and [`Metrics`](https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.metrics) based on interface methods.",
"license": "MIT",
"readme": "README.md",
Expand Down
2 changes: 1 addition & 1 deletion src/src/SourceGenerator/Emitters/EmitterHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public static AttributeDeclarationOptions AggressiveInliningAttribute() =>
};

/// <summary>
/// Adds a finished <see cref="CodeWriter"/> as a generated source file. The writer's
/// Adds a finished <c>CodeWriter</c> as a generated source file. The writer's
/// disposable scopes must all be closed before calling this; materializing the source
/// validates that they are.
/// </summary>
Expand Down
2 changes: 1 addition & 1 deletion src/src/SourceGenerator/Emitters/GeneratedTypesEmitter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ namespace Purview.Telemetry.SourceGenerator.Emitters;
/// <summary>
/// Emits the marker-attribute templates injected into consuming compilations. Each template
/// previously shipped as a static embedded resource; it is now built in memory with a
/// <see cref="CodeWriter"/> inside <c>RegisterPostInitializationOutput</c>.
/// <c>CodeWriter</c> inside <c>RegisterPostInitializationOutput</c>.
/// </summary>
static class GeneratedTypesEmitter
{
Expand Down
Loading