Skip to content

make picking haproxy::globals::sort_options_alphabetic work#573

Open
trefzer wants to merge 1 commit into
puppetlabs:mainfrom
cirrax:fix_picking
Open

make picking haproxy::globals::sort_options_alphabetic work#573
trefzer wants to merge 1 commit into
puppetlabs:mainfrom
cirrax:fix_picking

Conversation

@trefzer

@trefzer trefzer commented Aug 14, 2023

Copy link
Copy Markdown

all the pick statements for the sort_options_alphabetic are useless, if the value is not optional !

all the pick statements for the sort_options_alphabetic are
useless, if the value is not optional !
@jst-cyr

jst-cyr commented Jul 13, 2026

Copy link
Copy Markdown
Member

@trefzer : My apologies that nobody has responded on this for so much time. I'm going through our pull requests across modules and came across this request here. Is this still an issue for you?

@trefzer

trefzer commented Jul 13, 2026

Copy link
Copy Markdown
Author

I think it's still a bug !
Either you allow undef or you remove the related pick() statements.
I use a copy of this (and other puppetlabs) modules anyway since the bad response times. So it does not have a direct impact for me or my customers ! But if puppetlabs goal is to supply quality modules to the public, you should definitly fix this bug !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants