Add changelog entry for policy violations in PR comments and checks - #21604
Conversation
Announces pulumi/pulumi-service#48886: pull request comments and commit checks on GitHub, GitLab, Bitbucket, and Azure DevOps now include a policy violations section. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ESqtgVYkQjmUjaPDSDhGy
Reviewer's guide v2 — not for the authorTip This is the reviewer's guide. Work through the PR author: your to-do list is the other review comment, "Author action guide" — nothing on this card is yours. Note What this PR changes:
The wrongness that would matter here is a misstated capability or limit — a reader who trusts "up to 40" or the list of supported providers and finds otherwise. Link, shortcode, filename/date, and frontmatter checks ran clean, and the claims were checked against public docs and this repo. Review confidence:
|
| ID | Where | Finding |
|---|---|---|
| F1 | content/releases/changelog/2026-09-14-policy-violations-in-pull-request-comments-and-checks.md L2 |
"Pulumi Cloud now includes a 'Policy violations' section in the pull request comment and commit check it posts when a preview or update runs with a policy pack." — verdict: unverifiable — nothing public documents the new section yet, so please confirm the feature name and scope match what shipped. 🛡️ Disputed by fallimic on 2026-09-14, model held. Scope is settled by the author's citation of pulumi-service#48886 — both update_pull_request_comment.tmpl and update_check_run_details.tmpl add the section, GetUpdateLogs streams EngineEventPolicy for previews as well as updates, and the four VCS providers match the shipped changelog fragment. One detail does not settle: the finding asked whether the heading renders literally as "Policy violations", and the author's own quote of the shipping templates says "## Policy Violations" (title case), while the entry writes "Policy violations". Reviewer call: quote the product string verbatim as "Policy Violations", or keep sentence case per the site heading convention since this reads as prose rather than a quoted UI label. |
Editorial stances introduced by this PR
Superlative, ranking, or comparative language the diff adds. No verdict — a page's own framing isn't fact-checkable — but confirm each is a stance the docs should take, and that no agent-written rewrite introduced it unasked.
None — the extractor found no positioning or comparison language in this PR's added lines.
✅ What you can rubber-stamp
- Facts: 4 factual claims checked — 2 verified clean, 1 flagged in the
⚠️ list, 1 settled — see the evidence page. - Mechanics: frontmatter sweep ran; 2 added internal link(s) resolve.
- Style: 0 advisory suggestion(s) left with the author; never blocking.
💡 Pre-existing issues in touched files: 0 — details on the evidence page.
📎 Full evidence: verification trail, investigation log, review history.
Review v2 · updated 2026-09-14T15:51:01Z · head commit 02bee8f
For the reviewer: the @claude <your point> #update-review re-adjudicates with your input.
Author action guide v2 — nothing blocks mergeNote Nothing here blocks merge — no open items need an answer from you. A human reviewer still approves the merge. This PR adds one changelog entry announcing that policy pack violations now appear in Pulumi Cloud's pull request comments and commit checks; the review checked its links, filename/date convention, frontmatter, and the factual claims it makes. 🚨 Fix or disagreeNothing to fix — this section is empty. ❓ Questions for youNo open questions for you. ✅ Resolved since last review
📎 Full evidence: verification trail, investigation log, review history. Review v2 · updated 2026-09-14T15:51:01Z · head commit 02bee8f How to answerEvery 🚨 and ❓ item above needs one of these before merge:
The Please don't edit, hide, or delete this comment — it is the review's record. Full mechanics: CONTRIBUTING.md §AI-assisted contributions. |
|
🤖 Review updated on @fallimic's request. |
|
Your site preview for commit 02bee8f is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-21604-02bee8f0.s3-website.us-west-2.amazonaws.com Changed pages: |
Adds a releases changelog entry for pulumi/pulumi-service#48886: pull request comments and commit checks on GitHub, GitLab, Bitbucket, and Azure DevOps now include a Policy violations section listing each mandatory and advisory violation from the policy packs that ran on the preview or update.
content/releases/changelog/2026-09-14-policy-violations-in-pull-request-comments-and-checks.md🤖 Generated with Claude Code
https://claude.ai/code/session_017ESqtgVYkQjmUjaPDSDhGy