Remove duplicate TypeScript version guidance on JS SDK page - #21596
workprentice[bot] wants to merge 1 commit into
Conversation
The Installation requirements section restated, in less detail, the same bundled-vs-project TypeScript version explanation that the TypeScript versions section covers fully further down the page. Trim the early copy to a single forward-pointing sentence. Fixes #21595
Reviewer's guide v1 — not for the authorTip This is the reviewer's guide. Work through the PR author: your to-do list is the other review comment, "Author action guide" — nothing on this card is yours. Note What this PR changes:
The risk here is a pointer that goes nowhere or a version fact that only existed in the deleted sentence — either would leave a reader unable to find which TypeScript versions Pulumi supports. Both anchor targets and the retained version detail were read on the head commit, and the page's factual claims were re-checked. Review confidence:
|
Author action guide v1 — nothing blocks mergeNote Nothing here blocks merge — no open items need an answer from you. A human reviewer still approves the merge. This PR replaces a duplicated TypeScript version paragraph in the JavaScript SDK page's "Languages" section with a pointer to the "TypeScript versions" section below; the review confirmed both anchor targets exist, that no version detail was lost, and that all four factual claims on the page check out. 🚨 Fix or disagreeNothing to fix — this section is empty. ❓ Questions for youNo open questions for you. 📎 Full evidence: verification trail, investigation log, review history. Review v1 · updated 2026-09-14T14:19:11Z · head commit 2eac83a How to answerEvery 🚨 and ❓ item above needs one of these before merge:
The Please don't edit, hide, or delete this comment — it is the review's record. Full mechanics: CONTRIBUTING.md §AI-assisted contributions. |
|
Your site preview for commit 2eac83a is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-21596-2eac83a8.s3-website.us-west-2.amazonaws.com Changed pages: |
|
Closing this as superseded by #21552. Both PRs rewrite the same paragraph at #21552 does the same job (drops the duplicated version detail, points at the page's own "TypeScript versions" section) and carries ~25 other copy edits to the same page, so it's the one with more in it. That also resolves #21595. One thing worth carrying over rather than losing: this PR's sentence keeps the fact that a template's pinned TypeScript version takes precedence over Pulumi's bundled compiler. #21552's replacement drops it. I've flagged that on #21552. If the glow-up gets rejected, reopen this -- it's the surgical version and it stands on its own. Generated by Claude Code |
Fixes #21595
What's wrong
The JavaScript language SDK page (
content/docs/iac/languages-sdks/javascript/_index.md) explained the same fact -- that Pulumi bundles TypeScript 3.8.3 for backward compatibility but a project's ownpackage.jsonversion (3.8 through TypeScript 6) takes precedence -- twice, in near-identical wording:### Languages, early in "Installation requirements": a full paragraph restating the bundled-version/compatibility-range facts.### TypeScript versions, further down: the same explanation repeated in more detail, including the fallback-loading mechanics and the TypeScript 6/7 boundary.The sibling Python and Go SDK pages keep their "Installation requirements" sections lean (a runtime note plus a link) and defer language-specific mechanics to their own dedicated sections -- neither has this front-loaded duplication.
Fix
Trimmed the early
### Languagescopy to a single forward-pointing sentence that links to#typescript-versions(which already covers the full explanation, including TypeScript 7 guidance), while preserving the link to the SDK reference guide. No content was removed -- only the redundant restatement, which now points to the single source of truth further down the same page.Validation
node ./scripts/lint/lint-markdown.js content/docs/iac/languages-sdks/javascript/_index.md-- 0 errors./scripts/prettier.sh --check content/docs/iac/languages-sdks/javascript/_index.md --ignore-path .prettierignore.union-- all matched files use Prettier code style#typescript-versionsanchor exists on the page (the### TypeScript versionsheading), so the new forward link resolves correctly.🧠 This PR was created by workprentice.