Repository navigation
varve outdated: never call a pin the index does not list its newest layer - #376
Merged
Merged
Conversation
…ayer (#375) With nothing newer in the signed index, the text output said "<pin> is the newest layer realm '<r>' has signed for line <l> (index #n)". That is false when the index does not list the pin, as when a layer is deposited and pinned before its index is published. relay's covalent 2026.11.16 against index #16 (ending at 2026.11.15) printed it, and an agent quoted it as fact. The sentence now comes from nothing_newer(): unchanged when the index lists the pin; otherwise it says the index signs nothing newer, does not list the pin, and names its newest entry. --json gains pin_listed. Tests: a pin absent from the index is never called its newest layer; a listed pin keeps the old sentence exactly (REQ-LAYERDIFF-001). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KEjmjczUmt6Rdd9DRKe75Z
avrabe
force-pushed
the
fix/outdated-pin-not-in-index
branch
from
November 19, 2026 09:29
3480336 to
5b951f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #375. In scope for v0.48.0 by maintainer decision, 2026-11-19.
When nothing in the signed index is newer than the pin,
varve outdatedprinted<pin> is the newest layer realm '<r>' has signed for line <l> (index #n). That is false when the index does not list the pin, which happens when a layer is deposited and pinned before its index is published.Reproducer: relay on varve 0.47.0, pinned to covalent 2026.11.16, with served index #16 ending at 2026.11.15. An agent quoted the sentence as fact. The JSON output was already correct.
Change. The sentence now comes from
nothing_newer():--jsongainspin_listed.cmd-outdated.mddocuments it.Tests (
outdated_wording_testsin main.rs, REQ-LAYERDIFF-001):Gate. CI is the first run of these gates, on the maintainer's call, because the mini's disk is saturated. Negative control: the first head (
34803367) makespin_listedalways true, which restores the old sentence, so the first test must go red. The real head is5b951f94.🤖 Generated with Claude Code
https://claude.ai/code/session_01KEjmjczUmt6Rdd9DRKe75Z