Skip to content

varve outdated: never call a pin the index does not list its newest layer - #376

Merged
avrabe merged 1 commit into
mainfrom
fix/outdated-pin-not-in-index
Nov 19, 2026
Merged

avrabe merged 1 commit into
mainfrom
fix/outdated-pin-not-in-index

Conversation

@avrabe

@avrabe avrabe commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Fixes #375. In scope for v0.48.0 by maintainer decision, 2026-11-19.

When nothing in the signed index is newer than the pin, varve outdated printed <pin> is the newest layer realm '<r>' has signed for line <l> (index #n). That is false when the index does not list the pin, which happens when a layer is deposited and pinned before its index is published.

Reproducer: relay on varve 0.47.0, pinned to covalent 2026.11.16, with served index #16 ending at 2026.11.15. An agent quoted the sentence as fact. The JSON output was already correct.

Change. The sentence now comes from nothing_newer():

  • When the index lists the pin, the sentence is unchanged.
  • When it does not, the output says the index signs nothing newer, does not list the pin, and names its newest entry.

--json gains pin_listed. cmd-outdated.md documents it.

Tests (outdated_wording_tests in main.rs, REQ-LAYERDIFF-001):

  • A pin absent from the index is never called its newest layer.
  • A listed pin keeps the old sentence exactly.

Gate. CI is the first run of these gates, on the maintainer's call, because the mini's disk is saturated. Negative control: the first head (34803367) makes pin_listed always true, which restores the old sentence, so the first test must go red. The real head is 5b951f94.

🤖 Generated with Claude Code

https://claude.ai/code/session_01KEjmjczUmt6Rdd9DRKe75Z

…ayer (#375)

With nothing newer in the signed index, the text output said
"<pin> is the newest layer realm '<r>' has signed for line <l> (index #n)".
That is false when the index does not list the pin, as when a layer is
deposited and pinned before its index is published. relay's covalent
2026.11.16 against index #16 (ending at 2026.11.15) printed it, and an
agent quoted it as fact.

The sentence now comes from nothing_newer(): unchanged when the index
lists the pin; otherwise it says the index signs nothing newer, does not
list the pin, and names its newest entry. --json gains pin_listed.

Tests: a pin absent from the index is never called its newest layer; a
listed pin keeps the old sentence exactly (REQ-LAYERDIFF-001).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KEjmjczUmt6Rdd9DRKe75Z
@avrabe
avrabe force-pushed the fix/outdated-pin-not-in-index branch from 3480336 to 5b951f9 Compare November 19, 2026 09:29
@avrabe
avrabe merged commit 1b07665 into main Nov 19, 2026
54 checks passed
@avrabe
avrabe deleted the fix/outdated-pin-not-in-index branch November 19, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

varve outdated text calls the pin the index's newest layer even when the index does not list it

1 participant