Skip to content

Extend tests with PQC coverage - #1535

Merged
dralley merged 1 commit into
pulp:mainfrom
dralley:pqc
Oct 1, 2026
Merged

dralley merged 1 commit into
pulp:mainfrom
dralley:pqc

Conversation

@dralley

@dralley dralley commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Assisted-By: Codex 5.6 Luna

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

@dralley
dralley force-pushed the pqc branch 5 times, most recently from d9078c4 to f6bdfb4 Compare September 22, 2026 19:45
@dralley
dralley requested a review from hstct September 22, 2026 19:46
@dralley
dralley marked this pull request as ready for review September 22, 2026 19:46
@dralley

dralley commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

@pedro-psb See: the "phase out" test removal

@dralley

dralley commented Sep 22, 2026

Copy link
Copy Markdown
Contributor Author

Does not test: actually verifying the signatures on sync, since that requires more involved fixture changes. I can file an issue for that if desired.

Assisted-By: Codex 5.6 Luna
@pedro-psb

Copy link
Copy Markdown
Member

@pedro-psb See: the "phase out" test removal

Damn, it worked...

Comment thread pyproject.toml
# All things django and asyncio are deliberately left to pulpcore
# Example transitive requirements: asgiref, asyncio, aiohttp
"pulpcore>=3.113.0,<3.130",
"pulpcore>=3.117.2,<3.130",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.118 is the latest supported

@quba42

quba42 commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

@pedro-psb Does this mean we should backport this to our supported branches, since the CI Update wants to raise the floor, which triggers the reminder test? e.g.: #1543

@pedro-psb

Copy link
Copy Markdown
Member

@pedro-psb Does this mean we should backport this to our supported branches, since the CI Update wants to raise the floor, which triggers the reminder test? e.g.: #1543

I'm not sure why pulpbot started bumping pulpcore's lowerbound. We usually do that manually when we have a reason to. I guess I'm missing something...

But if you really wanna bump it on supported branches, then sure, backport the test removal.

@quba42

quba42 commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

I'm not sure why pulpbot started bumping pulpcore's lowerbound. We usually do that manually when we have a reason to. I guess I'm missing something...

@pedro-psb: I am going to drop a link to what @mdellweg told me here: #1542 (comment)

@pedro-psb

Copy link
Copy Markdown
Member

Oh, that makes some sense. Thanks

@hstct hstct left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea this is good!

@dralley
dralley merged commit e4a0382 into pulp:main Oct 1, 2026
14 checks passed
@dralley
dralley deleted the pqc branch October 1, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants