docs: document pulp-api and pulp-content auto-scaling - #1482
Open
carlosthe19916 wants to merge 1 commit into
Open
carlosthe19916 wants to merge 1 commit into
carlosthe19916 wants to merge 1 commit into
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the architecture documentation to describe the existing KEDA auto-scaling behavior for pulp-api and pulp-content, including replica bounds, metrics, scaling policies, and environment-specific configuration. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="docs/ARCHITECTURE.md" line_range="546-547" />
<code_context>
- Readiness: GET `/api/pulp/api/v3/livez/` (delay: 5s, period: 60s)
- Liveness: GET `/api/pulp/api/v3/livez/` (delay: 10s, period: 120s)
+- **Auto-scaling**:
+ - Min replicas: 1 (configurable via `PULP_API_MIN_REPLICA_COUNT`; production: 50 on `crcp01ue1`, 15 on `pulpp01ue1`)
+ - Max replicas: 10 (configurable via `PULP_API_MAX_REPLICA_COUNT`; production: 50 on `crcp01ue1`, 30 on `pulpp01ue1`)
+ - Trigger: Prometheus metric `pulp_api_active_connections` (scales on average concurrent requests per pod; threshold tuned in `deploy/clowdapp.yaml`)
+ - Scale up: 5 pods per 30s
</code_context>
<issue_to_address>
**issue:** The API auto-scaling subsection states that production uses a minimum of 50 replicas on `crcp01ue1` and 15 on `pulpp01ue1`, while the production topology table states 50 and 10 API pods respectively. The documented topology is therefore internally contradictory, and the table's 10-pod deployment is below the documented production minimum of 15.
**Triggers:** When readers use the production topology table and the new auto-scaling subsection together.
**Suggested fix:** Update either the production topology table or the production override values in the auto-scaling subsection so both describe the same replica ranges.
```suggestion
- Min replicas: 1 (configurable via `PULP_API_MIN_REPLICA_COUNT`; production: 50 on `crcp01ue1`, 10 on `pulpp01ue1`)
- Max replicas: 10 (configurable via `PULP_API_MAX_REPLICA_COUNT`; production: 50 on `crcp01ue1`, 10 on `pulpp01ue1`)
```
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: docs/ARCHITECTURE.md:547
Add Auto-scaling subsections for pulp-api and pulp-content in ARCHITECTURE.md, matching the existing pulp-worker entry, and list the new PULP_API/CONTENT_MIN/MAX_REPLICA_COUNT deployment parameters. Both deployments now have KEDA autoScaler blocks in deploy/clowdapp.yaml. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
carlosthe19916
force-pushed
the
docs-api-content-autoscaling
branch
from
September 17, 2026 09:08
5a9571f to
c193391
Compare
Contributor
Author
|
@sourcery-ai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Auto-scaling subsections for
pulp-apiandpulp-contentindocs/ARCHITECTURE.md, mirroring the existingpulp-workerentry, and lists the newPULP_API/CONTENT_MIN/MAX_REPLICA_COUNTdeployment parameters.Both deployments now have KEDA
autoScalerblocks indeploy/clowdapp.yaml(triggering onpulp_api_active_connections/pulp_content_active_connections), but were previously undocumented. Docs-only change.🤖 Generated with Claude Code
Summary by Sourcery
Documentation:
pulp-apiandpulp-contentdeployments, including replica limits, metrics, and scaling policies.