refactor(bender-slang)!: pass slices instead of vectors across FFI - #357
Merged
Merged
Conversation
Member
|
This will require a new bender-slang version to be released, right? |
Contributor
Author
|
yes, I think it was anyway due, since there were some other changes as well. |
micprog
force-pushed
the
slang-ffi-slices
branch
from
September 9, 2026 15:37
3420e74 to
87fd1fc
Compare
…opriate Saves a few over-allocations and is generally more idiomatic since those are all read-only values
micprog
force-pushed
the
slang-ffi-slices
branch
from
September 9, 2026 16:01
87fd1fc to
fe8f41b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generally, all of those are anyway read-only and this gets rid of a few unnecessary re-allocations.