Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, correct wiring fix (explicitly setting a previously omitted struct field) with low regression risk and a matching changelog entry.
Pull request overview
This PR restores correct propagation of the fault_only_first control bit by explicitly forwarding it from the sequencer’s incoming request (ara_req_i) into the processing-element request (pe_req_d), preventing it from being implicitly cleared by the struct literal default: '0.
Changes:
- Forward
fault_only_firstinto the PE request struct initialization inara_sequencer.sv. - Document the fix in
CHANGELOG.md.
File summaries
| File | Description |
|---|---|
| hardware/src/ara_sequencer.sv | Adds explicit fault_only_first field assignment in the PE request struct literal so it is not zeroed by the default initializer. |
| CHANGELOG.md | Notes the forwarding fix under “Fixed”. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward
fault_only_firstinto the PE request. The omitted field was zeroed bydefault: '0, disabling the existing fault-only-first handling added in #380.Validation: syntax and diff checks; full-core simulation not rerun. Changelog updated.