Skip to content

[hardware] Forward the fault-only-first flag - #492

Open
flaviens wants to merge 1 commit into
pulp-platform:mainfrom
flaviens:codex/forward-fault-only-first
Open

flaviens wants to merge 1 commit into
pulp-platform:mainfrom
flaviens:codex/forward-fault-only-first

Conversation

@flaviens

Copy link
Copy Markdown

Forward fault_only_first into the PE request. The omitted field was zeroed by default: '0, disabling the existing fault-only-first handling added in #380.

Validation: syntax and diff checks; full-core simulation not rerun. Changelog updated.

Copilot AI lite review requested due to automatic review settings September 11, 2026 11:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a minimal, correct wiring fix (explicitly setting a previously omitted struct field) with low regression risk and a matching changelog entry.

Pull request overview

This PR restores correct propagation of the fault_only_first control bit by explicitly forwarding it from the sequencer’s incoming request (ara_req_i) into the processing-element request (pe_req_d), preventing it from being implicitly cleared by the struct literal default: '0.

Changes:

  • Forward fault_only_first into the PE request struct initialization in ara_sequencer.sv.
  • Document the fix in CHANGELOG.md.
File summaries
File Description
hardware/src/ara_sequencer.sv Adds explicit fault_only_first field assignment in the PE request struct literal so it is not zeroed by the default initializer.
CHANGELOG.md Notes the forwarding fix under “Fixed”.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants