Repository navigation
docs: correct request timeout units to seconds - #544
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
pcbeingused333
requested review from
jguz-pubnub,
mohitpubnub and
parfeon
as code owners
November 12, 2026 07:39
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #537
The request timeout options and their getters describe milliseconds, but the configuration values are seconds and transports convert them to milliseconds. Correct the six JSDoc comments in the configuration interface and the three corresponding option comments in the published type declarations. Defaults and runtime behavior are unchanged.
Testing and validation
A focused documentation check fails against master and passes all nine assertions with this change.
git diff --checkpasses.Dependency installation (
npm ci --ignore-scripts --no-audit --no-fund) failed with EACCES in the npm cache. Type declaration regeneration and the Node build could not run; the published declaration comments were synchronized directly with the source.This change was prepared with assistance from an AI coding agent.