Repository navigation
harness setup - #536
Open
mohitpubnub wants to merge 7 commits into
Open
harness setup#536mohitpubnub wants to merge 7 commits into
mohitpubnub wants to merge 7 commits into
Conversation
…ns and verificationas to make pre-commit checks mandatory
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
… at EOF package.json
mohitpubnub
added
the
priority: medium
parfeon
approved these changes
Nov 9, 2026
parfeon
left a comment
parfeon
left a comment
Contributor
There was a problem hiding this comment.
LGTM (with few clarification questions)
| @@ -0,0 +1,16 @@ | |||
| #!/bin/bash | |||
| # Stop hook. Don't let the agent finish with a failing type check. Keep it under ~30 s. | |||
Contributor
There was a problem hiding this comment.
A bit confusing statement especially if we skip check when node_modules is missing and we don't force user to run npm ci.
|
|
||
| ## Commands | ||
| - Install: `npm install`, as `run-tests.yml` does. Use Node 22 or 24, the CI matrix. Mocha fails at startup on Node 26; that's environmental, not an SDK bug. | ||
| - Build (no keys needed): `npm run build:node` (tsc → `lib/` + aggregated `lib/types/index.d.ts`) · `npm run build:web` (rollup → `dist/web/`). Run `build:node` before the `release` or `node` suite. |
Contributor
There was a problem hiding this comment.
There is actually no need to run build:node before release because release bot does run npm run build before committing change logs. But in case if something has been changed after - then yes.
Comment on lines
+7
to
+8
| | [sdk-specifications](https://github.com/pubnub/sdk-specifications) | `test/specs` | `npm run test:contract:prepare` (rm + shallow clone of `master`) | | ||
| | [service-contract-mock](https://github.com/pubnub/service-contract-mock) | `dist/contract` | `npm run contract:refresh` (rm + clone + npm install) | |
Contributor
There was a problem hiding this comment.
I would move these addresses into .env file instead of hardcoding them here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs: repository harness setup files