Repository navigation
crypto-updates - #533
Open
mohitpubnub wants to merge 16 commits into
Open
crypto-updates#533mohitpubnub wants to merge 16 commits into
mohitpubnub wants to merge 16 commits into
Conversation
…or encrypt and decrypt to be MaybePromise because a custom cryptor can still be syncronous as per user wish, updates publish, subscribe, fetchMessages, history apis to handle encryption,decryption with async methods with the help of prepare and promise.all. added utility bytes.ts for one common place for required bytes operation across the apis. updated node crypto module to use its prmitive and same for the web cryptomodule for crypto.subtle use. noble for react native platform, added as optional peer dependency.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…with decryptor list
mohitpubnub
added
priority: medium
…, updated relevant references
parfeon
approved these changes
Nov 9, 2026
parfeon
left a comment
parfeon
left a comment
Contributor
There was a problem hiding this comment.
Mostly LGTM
Few clarification requests has been left.
| if (preparation) { | ||
| // Requests which require preparation are scheduled in call order (same as synchronous requests). | ||
| const orderedPreparation = this.requestsPreparation.then(() => preparation); | ||
| this.requestsPreparation = orderedPreparation.catch(() => {}); |
Contributor
There was a problem hiding this comment.
But why we silence crypto errors?
Contributor
Author
There was a problem hiding this comment.
The empty .catch(() => {}) does not hide crypto errors. It only resets the preparation-queue tail so one failed prepare() does not reject every later encrypted request.
This call still awaits orderedPreparation, and that rejection goes to handleRequestError
| "node_modules", | ||
| "test", | ||
| "src/file/modules/node.ts", | ||
| "src/crypto/primitives/react-native.ts", |
Contributor
There was a problem hiding this comment.
Should we also exclude Node's primitives?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(crypto-library): Remove bundled CryptoJS.
Replaced the bundled CryptoJS with native crypto on web, Node.js and noble on React Native.
BREAKING CHANGES: Web: encrypt()/decrypt() now return Promises, and encryption needs crypto.subtle (HTTPS or localhost). Runtimes without it, such as tvOS TVMLKit, can no longer encrypt or decrypt.
React Native: encrypt()/decrypt() now return Promises. Apps using cipherKey must install @noble/ciphers, @noble/hashes and react-native-get-random-values.
feat: support for aes gcm type decryption
add support for aes gcm type decryption by adding cryptor with decryption capability.