Repository navigation
fix(frontend): disconnect injected wallet locally - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the real MetaMask reconnect failure after an ExeKPro Disconnect. wagmi’s stock injected connector sends
wallet_revokePermissionsduring disconnect, but its local timeout does not cancel the MetaMask request. A following injected connect can race the still-pending revocation/permission lifecycle and MetaMask rejects it as already processing.Earlier polling and retry approaches could only react to variable wallet timing; they could not eliminate the outstanding revocation request.
ExeKPro Disconnect now clears only its application/wagmi connection state and deliberately does not revoke the MetaMask site permission. Reconnect uses the normal injected connect path without racing a pending permission revocation.
multiInjectedProviderDiscoveryis disabled deliberately: otherwise an automatically discovered stock injected connector could bypass the local-only disconnect wrapper. The trade-off is one legacywindow.ethereuminjected connector instead of per-wallet EIP-6963 selection.Regression coverage
The permanent frontend E2E now verifies connect → disconnect → immediate reconnect → successful reconnect and records provider RPC methods to assert normal application Disconnect never calls
wallet_revokePermissions.Validation
./scripts/deploy-local.sh; configured deterministic addresses matched deployed code.npm run e2e --workspace=apps/frontendpassed.npm run typecheckpassed.npm run build --workspace=apps/frontendpassed.git diff --checkpassed.