Upgrade GCC 13.2.0 version (PPU-SPU) - #121
humbertodias wants to merge 160 commits into
Conversation
|
Hey cool work, I really want gcc 13 on ps3. But you just forgot to credit Darjan Krijanand and luizfernandonb :/ |
Yeah.. I left his name on patch's file given him the credit |
Thanks. However, please don't slap a new upstreams version on the master branch; we have an You don't need to make a separate pull request for the upstream branch; just keep the same structure in your own repo and submit the master branch commit with the merge intact and we can work with that. If the new gcc version has diverged too much for a merge to be practical, it's better to create a new repo (still with an This may all seem like extra work, but it does ensure maintainability going forward. |
Thanks for the guidance - I've restructured this PR to match that workflow. upstream on my fork is a clean import of gcc-13.2.0.tar.xz (tag gcc-13.2.0-upstream), with no PS3 changes. The ps3toolchain patch can be generated with: Please, let me know if i missed anything. |
|
Perfect! Thank you. Now it's also easier to review. |
|
I wanna see this update, GCC's improved auto-vectorizer and SNS modules significantly improves performance. |
|
GCM samples from PSL1GHT should be compiled with the update because if I remember correctly, GCM stuff wasn't working well when I tested when the PR was created. |
|
On my PS3 Moonlight project i compiled pr for myself. I didn't see any problems with that, my project utilized Tiny3D for display. |
|
Tested with SoRR bennug64-port-ps3.mp4 |
|
@humbertodias Your gcc updates have been merged through the gcc-PS3 repository. |
Keep split PPU/SPU/host patches and gcc-PS3 PPU delta (no TARGET_USES_LINUX64_OPT). Take master's newlib dirent sentinels and SPU --with-newlib/--with-pic.
The upstream merge left a cat of gcc-9.5.0-PS3.patch; SPU already uses the -SPU/-host/-macos-arm64 patches.
Sure! master branch merged into this PR |
Keep split GCC patches; also refresh newlib config.guess/config.sub and keep SPU --with-system-zlib.
The last master merge applied those hunks to gcc-13.2.0-PS3-PPU.patch; they already exist in GCC 13 and make GNU patch fail on Linux after zlib.
thanks for all your efforts here @humbertodias 👍 I've triggered the CI checks to confirm everything builds ok. Please follow up with zeldin if you have questions or need another review. 🙏 |
This reverts commit ec5410b.
|
Could the docker ci be skipped for pull requests? |
…h # fails closed in a few seconds when those secrets are unavailable
Sure! Skipped 6f580ea |
|
So, looking at the current "Files changed" for this PR, there are a few unrelated changes here:
These should be made into separate PRs so that they can be reviewed and merged (if appropriate). In addition there's a bunch of other stuff which I don't think is relevant, like the utils functions to handle Kitchen sink PRs like this one can be useful to try get some testing of a complete set of changes, but they are not conductive to actual merging. 😸 |
GDB was causing issues building on macOS from what I remember and users can install GDB-Multiarch to get the same result, we also have no way to actually use GDB outside RPCS3 from what I know. I can look into restoring it. |
Sounds like a better solution would be to fix the build issues then. Probably there is some upstreams commit that can be backported. GDB should be able to interact with |
Features
Note
We've selected the version 9.5.0 because it's the last GCC release to include support for SPU.
https://www.phoronix.com/news/GCC-10-Drops-Cell-BE-SPU
Tip
Patches credits to disc-kuraudo and luizfernandonb
Result
https://github.com/humbertodias/ps3toolchain/actions/runs/8166663270
Note
Don't forget to create a named DockerHub environment on your repository with two secret variables: DOCKERHUB_USERNAME and DOCKERHUB_TOKEN
badges

PSL1GHT hello game