Skip to content

ci: speed up PR compatibility checks #2567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zeitlinger wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: speed up PR compatibility checks #2567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .mise/lib/jmx_exporter_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,15 +153,16 @@ def run_maven_test(
prom_version = get_prom_version()
# Build the full reactor (including the integration_test_suite) the same way
# run-quick-test.sh does, but against our locally installed io.prometheus
# artifacts. The pinned distribution env vars keep this to the quick (single
# cell) matrix rather than the full smoke-test matrix.
# artifacts. This PR check intentionally runs only one representative smoke
# test; the pinned distribution env vars also keep it to a single matrix cell.
env = {**os.environ, **quick_test_images(jmx_exporter_dir)}
cmd = [
"./mvnw",
"-B",
"clean",
"install",
f"-Dprometheus.metrics.version={prom_version}",
"-Dparamixel.match.class.regex=io.prometheus.jmx.test.core.BasicTest",
f"-Dparamixel.parallelism={os.cpu_count() or 1}",
"-Djacoco.skip=true",
]
Expand Down
2 changes: 1 addition & 1 deletion mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,10 @@ run = "./mvnw install -DskipTests -Dcoverage.skip=true"

[tasks.native-test]
description = "Run GraalVM native tests"
depends = "build"
tools.java = "oracle-graalvm-25"
# Native Test uses Surefire, so explicitly select the Failsafe-named test class.
run = '''
./mvnw -pl integration-tests/it-spring-boot-smoke-test -am install -DskipTests -Dcoverage.skip=true

@jaydeluca jaydeluca Oct 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this use mise like below?

Suggested change
./mvnw -pl integration-tests/it-spring-boot-smoke-test -am install -DskipTests -Dcoverage.skip=true
"$MISE_CONFIG_ROOT/mvnw" -pl integration-tests/it-spring-boot-smoke-test -am install -DskipTests -Dcoverage.skip=true

@zeitlinger zeitlinger Oct 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the working dir is the config root - so I don't see how this is making it easier

@jaydeluca jaydeluca Oct 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha

cd "$MISE_CONFIG_ROOT/integration-tests/it-spring-boot-smoke-test"
"$MISE_CONFIG_ROOT/mvnw" test -PnativeTest -Dtest=ApplicationIT
'''
Expand Down
Loading