fix: harden metric scrape edge cases#2297
Draft
zeitlinger wants to merge 1 commit into
Draft
Conversation
Contributor
|
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
6cc0f6c to
9a7bf86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This addresses the bug reports from #2282, #2283, #2284, #2285, #2286, and #2287 in one PR.
Bufferstripe indexing so large thread IDs cannot produce negative stripe indexes.Bufferspin wait during collection and replay buffered observations before failing the scrape on timeout.PrometheusPropertiesExceptionmessages.Fixes #2282
Fixes #2283
Fixes #2284
Fixes #2285
Fixes #2286
Fixes #2287
Validation
mise run lint:fix./mvnw -pl prometheus-metrics-core,prometheus-metrics-config,prometheus-metrics-exporter-common,prometheus-metrics-exporter-httpserver,prometheus-metrics-model test -Dcoverage.skip=true -Dcheckstyle.skip=truemise run build