Conversation
jkroepke
force-pushed
the
fix-finalizer-update-rbac
branch
from
September 19, 2026 09:33
1aa1a19 to
e7a79fa
Compare
3 tasks
Contributor
|
If this affects the release 0.94 we can have patch release, PR would need to target release-0.94 branch |
Contributor
|
Thanks! I submitted #8828 in parallel but my PR has a larger scope so let's keep yours. I agree that we need a patch release for this. |
jkroepke
force-pushed
the
fix-finalizer-update-rbac
branch
from
September 21, 2026 11:27
e7a79fa to
6e42a8b
Compare
jkroepke
force-pushed
the
fix-finalizer-update-rbac
branch
from
September 21, 2026 11:52
ecfd10d to
2e4af1d
Compare
OwnerReferencesPermissionEnforcement requires update permission on the owner's finalizers subresource when blockOwnerDeletion is set. Restore the permission only for the affected finalizer subresources. Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
jkroepke
force-pushed
the
fix-finalizer-update-rbac
branch
from
September 21, 2026 11:59
19a4920 to
c73592b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restore the
updatepermission on the owner'sfinalizerssubresource.OwnerReferencesPermissionEnforcementrequires this permission whenblockOwnerDeletionis set. The permission was previously included through the wildcard verbs and was removed in #8752 when the RBAC rules were restricted to explicit verbs.Type of change
CHANGEFEATUREBUGFIXENHANCEMENTNONEVerification
Updated the Jsonnet source and generated RBAC manifests consistently.
Changelog entry