Skip to content

namespace: allow setting labels and annotations - #11

Merged
BacLuc merged 1 commit into
masterfrom
allow-setting-namespace-metadata
Jul 27, 2026
Merged

BacLuc merged 1 commit into
masterfrom
allow-setting-namespace-metadata

Conversation

@BacLuc

@BacLuc BacLuc commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

To monitor this with https://github.com/appuio/component-solution-base-monitoring

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@BacLuc BacLuc added enhancement New feature or request bump:minor labels Jul 24, 2026
@github-actions

github-actions Bot commented Jul 24, 2026 •

Copy link
Copy Markdown

🚀 This PR has been released as v2.1.0

Triggering workflows Release

🛠️ Auto tagging enabled with label bump:minor

@BacLuc
BacLuc force-pushed the allow-setting-namespace-metadata branch from 0f90b55 to e58892b Compare July 24, 2026 08:38
@martini-source
martini-source requested a review from a team July 24, 2026 08:53
Comment thread component/main.jsonnet Outdated

@martini-source martini-source left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: I'd prefer to refactor the namespace parameter to be a dict, with keys: name, labels and annotations, instead of having 3 separate top level parameters like this.

@BacLuc

BacLuc commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Nitpick: I'd prefer to refactor the namespace parameter to be a dict, with keys: name, labels and annotations, instead of having 3 separate top level parameters like this.

Me too, but consistency is also good.
In the appuio lab:

grep -rh 'namespaceLabels:' dependencies/**/defaults.yml
    namespaceLabels: {}
      namespaceLabels: {}
      namespaceLabels: {}
      namespaceLabels: ${appcat:namespaceLabels}
      namespaceLabels: ${appcat:namespaceLabels}
      namespaceLabels: ${appcat:namespaceLabels}
    namespaceLabels:
    namespaceLabels: {}
    namespaceLabels: {}
    namespaceLabels: {}
    namespaceLabels: {}
    namespaceLabels:
    namespaceLabels: {}
    namespaceLabels: {}
    namespaceLabels: {}

I saw this in quite a few components.

@BacLuc
BacLuc force-pushed the allow-setting-namespace-metadata branch from e58892b to 82da5e6 Compare July 24, 2026 09:13
@BacLuc
BacLuc merged commit 05f9471 into master Jul 27, 2026
9 checks passed
@BacLuc
BacLuc deleted the allow-setting-namespace-metadata branch July 27, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bump:minor enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants