Repository navigation
namespace: allow setting labels and annotations - #11
Merged
Merged
Conversation
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
BacLuc
force-pushed
the
allow-setting-namespace-metadata
branch
from
July 24, 2026 08:38
0f90b55 to
e58892b
Compare
martini-source
approved these changes
Jul 24, 2026
martini-source
left a comment
There was a problem hiding this comment.
Nitpick: I'd prefer to refactor the namespace parameter to be a dict, with keys: name, labels and annotations, instead of having 3 separate top level parameters like this.
Contributor
Author
Me too, but consistency is also good. I saw this in quite a few components. |
BacLuc
force-pushed
the
allow-setting-namespace-metadata
branch
from
July 24, 2026 09:13
e58892b to
82da5e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To monitor this with https://github.com/appuio/component-solution-base-monitoring
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.