Repository navigation
Conversation
Nothing in this repository reads it. `make docs-serve` runs the `ghcr.io/vshn/antora-preview` image, which brings its own UI bundles, and no Makefile, workflow or script refers to `playbook.yml`. It dates from the 2020 open-sourcing and the component template no longer generates it. It pins an old antora-ui-default bundle that no Renovate rule can see, so it shows up as a stale pin in every audit. Part of vshn/antora-ui#204. Signed-off-by: Aarno Aukia <aarno.aukia@vshn.ch> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the removal of the unused Antora playbook and obsolete UI bundle pin.
No open issues 🎉
What changed in this PR
Removes the unused Antora playbook as part of the cleanup of stale UI bundle pins. The existing documentation preview setup remains unchanged.
Changes:
- Deletes
playbook.yml, including its obsoleteantora-ui-default1.6 bundle pin and standalone site configuration.
| File | Description |
|---|---|
playbook.yml |
Deletes the unused Antora configuration and stale UI bundle pin. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
playbook.yml. Nothing in this repository reads it.make docs-serveruns theghcr.io/vshn/antora-previewimage, which brings its own UI bundles, and no Makefile, workflow or script refers toplaybook.yml. It dates from the 2020 open-sourcing and the component template no longer generates it.The file pins an old
antora-ui-defaultUI bundle. No Renovate rule can see that URL, so the pin never moves and turns up as stale in every audit of bundle pins. Deleting it is simpler than tracking a file nothing builds.Part of vshn/antora-ui#204, which removes the dead pins and moves the live ones to
vshn/antora-uiunder Renovate.Checklist
playbook(checked onmaster)🤖 Generated with Claude Code