fix(runner): use stdin only when no list provided - #297
dwisiswant0 wants to merge 1 commit into
Conversation
Read stdin only when no domains were loaded from -l/-list or the CLI config. Previously, a detected pipe replaced those domains with stdin input, or blocked waiting for EOF even though input was already available. Fixes #296 Signed-off-by: Dwi Siswanto <git@dw1.io>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (2)
Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. Walkthrough
ChangesParseFlags input handling
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~12 minutes Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Configured domains retain precedence over stdin, and the supplied test coverage addresses piped and idle stdin behavior. The change is ready to merge. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Warning Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use A rabbit reads each line, Comment |
Read stdin only when no domains were loaded from -l/-list or the CLI
config. Previously, a detected pipe replaced those domains with stdin
input, or blocked waiting for EOF even though input was already
available.
Fixes #296
Summary by CodeRabbit
Bug Fixes
Tests