Repository navigation
daemon: put the IPC socket in group adm via /etc/group, not auth.log - #290
Merged
Merged
Conversation
The root daemon took the socket's group from /var/log/auth.log. A journald-only box (bbs, no rsyslog) has no auth.log, so the socket stayed root:root and only root could reach the daemon. Look adm up in /etc/group, with auth.log as the fallback. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan18 finding(s) HIGH/CRITICAL: 1 | MEDIUM: 9 | LOW: 8
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On bbs the IPC socket was
root:root 0660, so only root could run the TUI/CLI against the daemon. The daemon took the socket's group from/var/log/auth.log. bbs is journald-only (no rsyslog), so that file doesn't exist, and the chown was skipped. NowadmGid()readsadmfrom /etc/group, falls back to auth.log's group, and returns null (root:root) only when neither exists.Tests: socket-adm-group.test.ts (no auth.log, admin vs adm, fallback, neither). CLI 530/530, tsc clean.
🤖 Generated with Claude Code