Repository navigation
install-service: rotate /var/log/threatcrush (daily or 200M, keep 7) - #289
Merged
Merged
Conversation
Nothing rotated the daemon log, so dev2's threatcrushd.log reached 21 GB. install-service now writes /etc/logrotate.d/threatcrush. The daemon reopens the file on every append, so a plain rename rotates cleanly without copytruncate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan18 finding(s) HIGH/CRITICAL: 1 | MEDIUM: 9 | LOW: 8
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev2's
/var/log/threatcrush/threatcrushd.logwas 21 GB: nothing ever rotated it.install-servicenow writes/etc/logrotate.d/threatcrush(daily, or sooner at 200M, keep 7, compress + delaycompress). The daemon appends withappendFileSync, reopening the file on every line, so rename +createrotates cleanly. No copytruncate, which would copy 21 GB first. Skipped on boxes without /etc/logrotate.d.Tests: renderLogrotate in service.test (pattern, daily/maxsize/rotate 7/compress, no copytruncate). CLI 526/526, tsc clean.
logrotate -don dev2 parses the config: "log needs rotating".🤖 Generated with Claude Code