Repository navigation
daemon: start a newly written fail2ban jail with a full reload - #288
Merged
Merged
Conversation
`fail2ban-client reload threatcrush` only reloads a jail the server already runs; for the jail threatcrushd has just written it answers NOK, so with the EROFS fixed (#287) the first ban on a fail2ban box still failed. Fall back to a plain `reload`, which starts new jails and keeps existing bans. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan18 finding(s) HIGH/CRITICAL: 1 | MEDIUM: 9 | LOW: 8
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #287, found while verifying it live on vienna (fail2ban backend). With /etc/fail2ban writable, the jail + filter files are created, then
fail2ban-client reload threatcrushanswersNOK: ('threatcrush',)because a new jail can't be reloaded by name, so the first ban still failed. Now:reload <jail>, falling back to a fullreload(starts new jails, keeps existing bans). Confirmed on vienna by hand: after a full reload,threatcrush blocklands in the jail and nft.Tests: new fail2ban-new-jail.test.ts (fresh jail → full reload → banip; running jail → no reload). CLI suite 524/524, tsc clean.
🤖 Generated with Claude Code