Repository navigation
install.sh: download the bun installer in full before running it - #1023
Merged
Merged
Conversation
A curl | bash pipe runs whatever arrived if the transfer is cut off. Flagged by ThreatCrush (CWE-494) on the vendored copy in profullstack/cli-tools#118. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
ThreatCrush Security Scan53 finding(s) HIGH/CRITICAL: 1 | MEDIUM: 17 | LOW: 35
…and 3 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Piping the bun installer from
curlstraight intobashruns whatever arrived, even when the transfer is cut off. ThreatCrush flagged it (CWE-494, high) on the vendored copy in profullstack/cli-tools#118.The installer is now downloaded in full first (
curl -fsSL --retry 3 -o <tmp>) and then run withbash <tmp>. deploy-ssh tests: 14/14 pass. shellcheck is clean.🤖 Generated with Claude Code