Repository navigation
fix(brisk): drop screenshot placeholders on the pwa host; fix sweep test breakage - #273
Merged
Merged
Conversation
The pwa sweep moved the brisk adapter to brisk.pwa.pit.world but, by design, left the regex-escaped brisk\.news in SCREENSHOT alone. brisk builds its /api/screenshot placeholder URLs on its own host, so once it serves from the pwa host those placeholders would be carried into the collection as item images. Match both hosts. Also fixes the rest of the CI breakage from the sweep: - reflow house-aggregators.test.js, whose longer URLs broke biome format (the step that failed in CI and hid the test failures below); - installmap recordId test expected agenticjobs.work for an endpoint the sweep had moved to agenticjobs.pwa.pit.world. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on main went red after #272. The failing step was
bun run lint(biome format ontest/house-aggregators.test.js: the longer pwa URLs pushed lines past the width), which stopped CI beforebun test. Running the suite locally showed two more sweep-caused failures, one of them a real runtime bug.Runtime fix (brisk adapter):
SCREENSHOTstill matched onlybrisk\.news(the sweep deliberately skipped regex-escaped forms), whileBASEnow points atbrisk.pwa.pit.world. brisk builds its on-demand/api/screenshotplaceholder on its own host, so from the pwa host those placeholders would be stored as item images. The regex now matches both hosts; the test covers both.Test-only:
test/house-aggregators.test.js: biome reflow.test/installmap.test.js:recordId('https://agenticjobs.pwa.pit.world/api/mcp')isagenticjobs.pwa.pit.world, notagenticjobs.work(the sweep changed the input only).Local: lint clean; full
bun testwith Postgres 17 + Redis 7 was 2692 pass / 3 fail before the fix; two of those were the ones above. The third,credit codes > a code becomes a free Premium term, timed out at 5s under full-suite load on dev2 (NOAUTH noise from the box's own Redis), passes alone (13/13), and the sweep did not touch it.🤖 Generated with Claude Code