Repository navigation
test: a pwa.pit.world host is read in full, brand first - #441
Merged
Merged
Conversation
The domain sweep (#438) changed this test's input to brisk.pwa.pit.world but kept the expected 'brisk dot news'. The narration speaks the domain an ad points at so a listener can type it, and brisk.news is lapsing, so the right reading of the new host is 'brisk dot P W A dot pit dot world' (brand from the lexicon, PWA spelled as an initialism). Asserts that, plus a leet-named retired app (c0upons). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan50 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 30 | LOW: 18
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master CI has been red since #438:
tests/ads-video-spoken.test.tsgot inputbrisk.pwa.pit.worldbut kept expectingbrisk dot news.Choice of fix.
spokenDomainreads the domain the ad sends people to, so a listener can type it. Speakingbrisk dot newsfor an ad that points atbrisk.pwa.pit.worldwould send listeners to a domain that is lapsing. The code already says the brand naturally (brisk/couponsfrom the lexicon) and spells PWA as an initialism, so the expectation now matches it:brisk dot P W A dot pit dot world, plusc0upons.pwa.pit.world -> coupons dot P W A dot pit dot world. Test-only; no runtime change. Supersedes #440, which restored thebrisk.newsinput instead (green, but pins the test to a retiring domain).Local: the file passes; full suite 3038 pass, 3 timeouts under full-suite load (
ads-short-codes,ads-trend-serving) that pass in isolation and are unrelated.🤖 Generated with Claude Code