Repository navigation
Use global CoinPay wallets across all publisher slots - #419
Merged
Merged
Conversation
ThreatCrush Security Scan48 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 30 | LOW: 16
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishers had to enter a payout address separately for each site, and Connect wallet depended on an unreleased browser extension. The slots page now offers one CoinPay connection and one global destination for all current and future sites.
Add opt-in
wallet:readto the existing authorization-code/PKCE S256/OIDC connection flow. Import active account-level and linked global web-wallet receive addresses using the provider-verified subject; exclude business-scoped addresses. Store public metadata only, with no bearer tokens, refresh tokens or signing keys. A central wallet selector controls every owned slot. Backend withdrawal resolution and slot API reads use the same effective destination, and a disconnected/empty global connection fails closed rather than falling back to old per-slot addresses. Existing customers retain legacy destinations until explicitly opting into global wallets.Add authenticated wallet GET/sync APIs and
crawlproof slots wallets [sync], reusing existing CrawlProof and CoinPay CLI sessions. The sync endpoint requires both identities, refuses conflicting links, ignores client-supplied addresses/subjects, and never persists or returns the CoinPay token. Ordinary CoinPay identity sign-in scopes remain unchanged. Return the browser to its original slots page/filter after connecting.Wallet metadata is a snapshot with a visible sync time. Refresh once after changes in CoinPay; the refreshed destination applies to all sites. No automatic funds movement is introduced.
Validation: full suite 2,995 passed / 9 skipped before five additional API authorization tests; latest focused tests 39 passed, covering actual payout target selection, subject isolation, disconnect/empty fail-closed behavior, PKCE, ignored injected destinations and no token storage. Typecheck and production build passed. Desktop 1440px/mobile 390px browser fixtures passed with no manual address input or horizontal overflow.
Release: apply
20261031000000_coinpay_global_wallets.sqlbefore deploying. The existing CrawlProof OAuth client registration now allowswallet:read(no other scope added); user consent is still required. The operator's existing CoinPay CLI session is expired and the CrawlProof account is not linked, so one fresh CoinPay connection is needed after deployment. No addresses must be entered for any of the 98 slots. No real withdrawals were performed.