Repository navigation
Fix pre-roll narration failing with the retired default voice - #416
Merged
Merged
Conversation
ThreatCrush Security Scan48 finding(s) HIGH/CRITICAL: 2 | MEDIUM: 30 | LOW: 16
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Narrated pre-rolls failed as
missing_narration_audiobecause the default Rachel voice now returns ElevenLabs HTTP 402payment_requiredfor this deployment's free tier. Synthesis swallowed that cause and returned null, while the renderer correctly required audio. Verified the available premade Sarah voice returns real audio for the affected campaign without an account upgrade.Use Sarah as the deployment-overridable default, speak the immutable approved narration, skip synthesis for silent snapshots, and preserve classified speech failures. Retry temporary network/rate-limit failures with bounded requests; stop retrying permanent access/payment/configuration errors before frame capture. Keep narrated renders from publishing without audio. Show advertiser-safe guidance instead of telling users to edit campaign copy to fix provider configuration.
Validation: full suite 2,986 passed / 9 skipped; focused narration/worker tests and real ffmpeg pipeline passed; root and worker typechecks and production build passed. An additional approved-script regression test passed after the full run.
After deployment, requeue only the reported failed campaign job
b6308c9d-dbf8-4fe6-a0bb-c72115201acdand verify its published video and audio assets. No campaign copy, budget, billing tier or API credentials are changed.