Repository navigation
icon: a style says which ground it needs - #99
Merged
Merged
Conversation
Rule 13 already observed that a style of near-black bodies and lit accents is right on a dark terminal and illegible on a printed page, and that only the set knows which is which — but it gave a reader no field to read, so every surface had to guess from the style id. `ground` is that field: light, dark or any, written into style_info. Only agentic-emissive is dark. It matters more now that the marks are re-rendered: the 22 whose own colour is too dark and too grey to emit come back emitting neutral white, and on a white tile they are simply not there. The logicsrc gallery drew exactly that until it could read this. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ThreatCrush Security Scan23 finding(s) HIGH/CRITICAL: 4 | MEDIUM: 10 | LOW: 9
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #98, which merged while this was being written.
Rule 13 of the spec already observed that a style of near-black bodies and lit accents is right on a dark terminal and illegible on a printed page, and that only the set knows which is which. It gave a reader no field to read, so every surface had to guess from the style id.
groundis that field —light,darkoranyinstyle_info. Onlyagentic-emissiveisdark.It matters more now that #98 re-renders the marks. The 22 marks whose own colour is too dark and too grey to emit (GitHub, Apple, OpenAI…) come back emitting neutral white, and on a white tile they are simply not there. The logicsrc gallery drew exactly that until it could read this field:
ground: darkVerified
npm run typecheck: cleannpx vitest run test/icon.test.ts test/icon-hq.test.ts: 33 passed--no-draw, no image calls):hqand the two light agentic styles reportany,agentic-emissivereportsdark🤖 Generated with Claude Code