Repository navigation
dev2-edge: restore_live extracts again; re-probes really re-probe - #253
Merged
Merged
Conversation
…probe restore_live ran extractall inside the new 'remove the :80 file' branch, after the tar was closed, so a failed re-apply restored nothing (#252). And probe_one called edge-sweep with /dev/null, which the usage check rejected before EDGE_SWEEP_ONE was looked at, so every re-probe read 000/000/000. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan41 finding(s) HIGH/CRITICAL: 15 | MEDIUM: 12 | LOW: 14
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found applying #252 on dev2:
restore_live: dev2-edge: route unrouted Moshpit names to the c0mpute edge #252 puttf.extractallinside the new "remove the :80 file" branch, after the tar was closed, so a failed re-apply raisedTarFile is closedand restored nothing. The live state stayed healthy (the sweep flagged only alt.2600, whose answer changed by design), but the safety net was off.edge-sweep: edge-box'sprobe_oneruns it with/dev/nullandEDGE_SWEEP_ONE, but the usage check ([ -f ]) ran first and rejected/dev/null, so every re-probe reported 000/000/000. Pre-existing; it made changed names look dead in the failure report. The single-name path now runs before the usage check.vitest dev2-edge 15/15;
EDGE_SWEEP_ONE=example.com edge-sweep /dev/nullnow answers.🤖 Generated with Claude Code