Repository navigation
fix(stores): text expiry_date vs date('now') on Postgres - #96
Merged
Merged
Conversation
…_date Postgres has no text >= date operator, so /stores/<slug> 404'd and /api/stores/<slug> returned 500. expiry_date is stored as TEXT 'YYYY-MM-DD' (and sometimes ''), so compare against a bound string in the same format. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan38 finding(s) MEDIUM: 32 | LOW: 6
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/stores/<slug>404'd and/api/stores/<slug>returned 500 with PGoperator does not exist: text >= date.coupons.expiry_dateis TEXTYYYY-MM-DD(or''), so a timestamptz/date migration is not safe. Both queries now bind today's UTC date as aYYYY-MM-DDstring, which compares correctly as text. Audited every other date query in apps/web: the rest bind ISO strings into timestamptz columns or use CURRENT_TIMESTAMP in assignments, which work.🤖 Generated with Claude Code